[bind10-dev] Bind9 doesn't reset last EOLN condition
Michal 'vorner' Vaner
michal.vaner at nic.cz
Wed Nov 21 13:27:16 UTC 2012
Hello
As raised during the review of #2375, the bind9 lexer code has a „last token was
EOLN“ variable in the state. The current bind10 code has it too. But when bind9
„ungets“ a token, it does not restore previous value of that variable, while my
code does. I find it more clean and logic (so ungetting a token makes it look it
was never actually read, while in bind9 code get+unget can sometimes have
sideeffect).
While I don't thing we want to continue this non-logic behaviour (after all, one
of the reasons for rewrite to bind10 is bind9 is hard to maintain and read), I'd
like to ask if anyone knows if it is on purpose in bind9 or just a bug that
never manifested (as the lexer is never asked to unget at the place where it
matters). If it is on purpose, what is the reason behind this (because I don't
find it could be helpful to anything).
Thank you
With regards
--
"It can be done in C++" says nothing. "It can be done in C++ easily" says nobody.
Michal 'vorner' Vaner
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 198 bytes
Desc: Digital signature
URL: <https://lists.isc.org/pipermail/bind10-dev/attachments/20121121/3a590727/attachment.bin>
More information about the bind10-dev
mailing list