[bind10-dev] src/bin/dbutil/tests fails if SHELL=/bin/csh
JINMEI Tatuya / 神明達哉
jinmei at isc.org
Thu Feb 7 18:38:09 UTC 2013
At Thu, 07 Feb 2013 14:21:51 +0900 (JST),
fujiwara at jprs.co.jp wrote:
>
> src/bin/dbutil/tests/dbutil_test.sh.in calls ../run_dbutil.sh using ${SHELL}.
> ${SHELL} ../run_dbutil.sh --upgrade --noconfirm $tempfile
>
> ${SHELL} is not controlled by BIND 10.
>
> These '${SHELL}' should be removed or replaced by @@SHELL@@.
>
> I prefer removing '${SHELL}' because configure sets execution bit of
> src/bin/dbutil/run_dbutil.sh and the first line of it is "#!/bin/sh".
>
> Most part of BIND 10 code assumes existence of /bin/sh. (and it is BSH.)
I agree ${SHELL} shouldn't be used in the script. I don't have a
strong opinion on the rest of the issue.
Could you open a ticket (I believe you can)? Email messages are
easily buried and forgotten.
---
JINMEI, Tatuya
Internet Systems Consortium, Inc.
More information about the bind10-dev
mailing list