[bind10-dev] release candidate progress

[Mukund Sivaraman]

On Wed, Feb 13, 2013 at 07:54:19AM -0800, JINMEI Tatuya / 神明達哉 wrote:
> I suggested several options, including only disabling the default
> account (+ documentation) without introducing new code.  If we
> consider it very important to kill the default account in the RC,
> that's one option.

Nod. Shane would be the best person to comment about this decision.

> 
> BTW, to be clear, it's not "additional tests": the new code had mostly
> no tests, much less developed test-driven, so I simply asked for
> "tests for the newly added code".

None of the code in cmdctl and bindctl (related to the login, and also
the code that both calls out from bindctl and handles the API call in
cmdctl) is tested.

One could throw something together as a test, but it is better if the HTTP
API code is comprehensively tested. I proposed that this be implemented
in a separate ticket (similar to the bug that you created and I fixed to
add comprehensive tests for BoB -> #2353) for all of this API. It
doesn't practically make a whole lot of difference if there was a test
for the "/users-exist" API call alone, when nothing else is tested. For
the POST calls, it would be better to write common test code for all the
calls.

For the code introduced unrelated to the HTTP API, a test was added. So
any new tests are additional tests. Does it have to be pointed out it
was not developed test-driven when I have said as much on the ticket
along with the reason for it?

		Mukund
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 801 bytes
Desc: not available
URL: <https://lists.isc.org/pipermail/bind10-dev/attachments/20130213/eddac0b2/attachment.bin>