[bind10-dev] BIND 10 trac3160, updated. 6faa17ef4f22d11d3fc653680d073ac61197d6b3 [3160] Log text representation of the AbstractRRset (contd.)

[Michal 'vorner' Vaner]

Hello

On Thu, Sep 12, 2013 at 08:44:40PM +0000, BIND 10 source code commits wrote:
> The branch, trac3160 has been updated
>        via  6faa17ef4f22d11d3fc653680d073ac61197d6b3 (commit)
>       from  66fadfe15f6cb482f9aa4f1d87177c872d16bbae (commit)
> - Log -----------------------------------------------------------------
> commit 6faa17ef4f22d11d3fc653680d073ac61197d6b3
> Author: Mukund Sivaraman <muks at isc.org>
> Date:   Fri Sep 13 02:09:24 2013 +0530
> 
>     [3160] Log text representation of the AbstractRRset (contd.)
> 
> -----------------------------------------------------------------------
> 
> Summary of changes:
>  src/lib/datasrc/database.cc |   12 ++++++------
>  1 file changed, 6 insertions(+), 6 deletions(-)
> 
> -----------------------------------------------------------------------
> diff --git a/src/lib/datasrc/database.cc b/src/lib/datasrc/database.cc
> index 9c85054..6cd1c5d 100644
> --- a/src/lib/datasrc/database.cc
> +++ b/src/lib/datasrc/database.cc
> @@ -718,11 +718,11 @@ DatabaseClient::Finder::logAndCreateResult(
>          if (wildname == NULL) {
>              LOG_DEBUG(logger, DBG_TRACE_DETAILED, log_id).
>                  arg(accessor_->getDBName()).arg(name).arg(type).
> -                arg(getClass()).arg(*rrset);
> +                arg(getClass()).arg(rrset->toText());
>          } else {
> ...

Why is this change needed? Shouldn't .arg use the generic << operator? Shouldn't
rrsets print themselves with that? I think that was the original intention and
if it doesn't work, it is broken and we should fix that instead of working
around it.

With regards

-- 
BOFH Excuse #430:

Mouse has out-of-cheese-error

Michal 'vorner' Vaner
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 198 bytes
Desc: Digital signature
URL: <https://lists.isc.org/pipermail/bind10-dev/attachments/20130916/30bc1076/attachment.bin>