[bind10-dev] Minor code change reviews added to code review procedure

[Mukund Sivaraman]

On Wed, Jan 29, 2014 at 05:07:29PM +0100, Shane Kerr wrote:
> FYI I've added a note about how we review minor code changes to our
> code review procedure:
> 
> http://bind10.isc.org/wiki/CodeReviewProcedure

I've added another item to run a "git grep <ticket-number>" in the
tree. We usually leave comments with a ticket number to rewrite code or
clean up some parts after that ticket has been resolved. These bits are
usually small enough to complete as part of the ticket being
reviewed. If they aren't, follow-up tickets can be created at that
point.

The grep check during review is necessary as the code to be updated may
be in a different part of the tree vs. what was worked on in the ticket.

		Mukund
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 2881 bytes
Desc: not available
URL: <https://lists.isc.org/pipermail/bind10-dev/attachments/20140202/5d96f7cf/attachment.bin>