<html xmlns:v="urn:schemas-microsoft-com:vml" xmlns:o="urn:schemas-microsoft-com:office:office" xmlns:w="urn:schemas-microsoft-com:office:word" xmlns:m="http://schemas.microsoft.com/office/2004/12/omml" xmlns="http://www.w3.org/TR/REC-html40"><head><meta http-equiv=Content-Type content="text/html; charset=us-ascii"><meta name=Generator content="Microsoft Word 12 (filtered medium)"><style><!--
/* Font Definitions */
@font-face
{font-family:SimSun;
panose-1:2 1 6 0 3 1 1 1 1 1;}
@font-face
{font-family:SimSun;
panose-1:2 1 6 0 3 1 1 1 1 1;}
@font-face
{font-family:Calibri;
panose-1:2 15 5 2 2 2 4 3 2 4;}
@font-face
{font-family:SimSun;
panose-1:2 1 6 0 3 1 1 1 1 1;}
/* Style Definitions */
p.MsoNormal, li.MsoNormal, div.MsoNormal
{margin:0cm;
margin-bottom:.0001pt;
font-size:11.0pt;
font-family:"Calibri","sans-serif";}
a:link, span.MsoHyperlink
{mso-style-priority:99;
color:blue;
text-decoration:underline;}
a:visited, span.MsoHyperlinkFollowed
{mso-style-priority:99;
color:purple;
text-decoration:underline;}
span.EmailStyle17
{mso-style-type:personal-compose;
font-family:"Calibri","sans-serif";
color:windowtext;}
.MsoChpDefault
{mso-style-type:export-only;}
@page WordSection1
{size:612.0pt 792.0pt;
margin:72.0pt 90.0pt 72.0pt 90.0pt;}
div.WordSection1
{page:WordSection1;}
--></style><!--[if gte mso 9]><xml>
<o:shapedefaults v:ext="edit" spidmax="1026" />
</xml><![endif]--><!--[if gte mso 9]><xml>
<o:shapelayout v:ext="edit">
<o:idmap v:ext="edit" data="1" />
</o:shapelayout></xml><![endif]--></head><body lang=EN-US link=blue vlink=purple><div class=WordSection1><p class=MsoNormal>When I review the code of MemoryZone find, I think the find function in rbtree has problem.<o:p></o:p></p><p class=MsoNormal><o:p> </o:p></p><p class=MsoNormal>In RBTree, we do NOT presume that all the domain names store in one rbtree belong to the same zone,<o:p></o:p></p><p class=MsoNormal> so there is no guarantee that root will be the Super domain of all the other domains. <o:p></o:p></p><p class=MsoNormal> But when we use it as memoryZone, in most case, root will NOT has left or right, <o:p></o:p></p><p class=MsoNormal>It only has down pointer, so the find call for any domain in the zone will always return PARTIALMATCH<o:p></o:p></p><p class=MsoNormal> which maybe not be what the user wants<o:p></o:p></p><p class=MsoNormal> <o:p></o:p></p><p class=MsoNormal>so the problem is that the check for root node if PARTIALMATCH returns should be put into rbtree or memoryzone ?<o:p></o:p></p><p class=MsoNormal>If we define rbtree as a general map mapping domain to anything else , the check should be put into memoryzone. <o:p></o:p></p><p class=MsoNormal>But if in this way, the find code in MemoryZone will look strange to me.<o:p></o:p></p><p class=MsoNormal><o:p> </o:p></p><p class=MsoNormal>A more general question is that rbtree should be uses to store the zone data or used as a general map?<o:p></o:p></p><p class=MsoNormal><o:p> </o:p></p><p class=MsoNormal><o:p> </o:p></p></div></body></html>