mysql_lease_mgr.h and CURRENT_VERSION_VERSION

[Tomek Mrugalski]

On 27.12.2012 21:52, Jeremy C. Reed wrote:
> src/lib/dhcpsrv/mysql_lease_mgr.h has:
> 
> // Define the current database schema values
> 
> const uint32_t CURRENT_VERSION_VERSION = 1;
> const uint32_t CURRENT_VERSION_MINOR = 0;
> 
> 
> Should CURRENT_VERSION_VERSION be called CURRENT_VERSION_MAJOR?  (I
> think "VERSION_VERSION" is confusing or at least redundant.)
We need to ask Stephen about that. I remember that we had a brief
discussion about that. I think the original reason was that originally
there was one version in one of the DNS modules. Later minor version
numbering was added to mark backward compatible changes. To maintain
consistent numbering between old and new versions, the version had to be
still named version. That automatic version comparison was needed for
dbutil - a tool that we hope one day will also support DHCP.

That's more or less the rationale here. Stephen will clarify/correct me
once he gets back.

I suggested that since DHCP component is brand new, we may do things the
right way and use major/minor version. I don't know how dbutil works and
if we even will use it (the alternative would be to develop dbutil-like
tool dedicated to DHCP maintenance). Anyway, let's discuss if we want to
keep our decision or revisit it.

Tomek