BIND 10 #50: Review data source and query logic

[BIND 10 Development]

#50: Review data source and query logic
--------------------------+-------------------------------------------------
 Reporter:  each          |        Owner:  jinmei                                           
     Type:  enhancement   |       Status:  assigned                                         
 Priority:  critical      |    Milestone:  02. Running, functional authoritative-only server
Component:  Unclassified  |   Resolution:                                                   
 Keywords:                |    Sensitive:  0                                                
--------------------------+-------------------------------------------------

Comment(by jinmei):

 Replying to [comment:17 shane]:
 > What is the status of this ticket? Last change was 6 weeks ago, and it's
 not clear if it is waiting on anything...

 Like the DNS library module, the problem is that this ticket is "too big".

 I suggest we forget things under lib/dns in the context of this ticket and
 get them reviewed as part of the DNS library module.

 Then, we can focus on things under lib/auth.  These have been reviewed to
 some extent, but at that time we've been making additional changes in
 parallel, so they may not be considered "fully reviewed".

 To be sure, it would be nice to have one more review cycle for these.  I'd
 separate them into the following set:

  1. data_source.{h,cc} and query.{h,cc} (and their tests)
  2. sqlite3_datasrc.{h,cc} (and their tests)
  3. static_datasrc.{h,cc} (and their tests)

 I had substantially modified 2 and 3 while I gave them my review, so
 someone else should review these.

 I also substantially modified 1, but I think I can safely be a reviewer of
 it.

 Notes:

  - There are specific open issues on this module already identified in
 previous reviews and ticketed.
  - One common, big issue for this module is the lack of documentation.  I
 suspect we can complete it for the next release, so it will probably be
 separate open tickets.
  - As I said somewhere (in another ticket or bind10-dev), I suspect we'll
 need to substantially revisit the whole design and implementation of this
 stuff (as well as the main auth server code in src/bin/auth) anyway.
 Assuming we agree on this, perhaps we can simply complete a lightweight
 review just for the next week's release, and restart the whole work mostly
 from the scratch.

-- 
Ticket URL: <https://bind10.isc.org/ticket/50#comment:18>
BIND 10 Development <http://bind10.isc.org>
BIND 10 Development