BIND 10 #141: review: some cleanups and minor bug fixes for xfrout

BIND 10 Development do-not-reply at isc.org
Fri Apr 16 03:29:45 UTC 2010


#141: review: some cleanups and minor bug fixes for xfrout
--------------------------+-------------------------------------------------
 Reporter:  jinmei        |        Owner:  zhanglikun
     Type:  defect        |       Status:  assigned  
 Priority:  minor         |    Milestone:            
Component:  Unclassified  |   Resolution:            
 Keywords:                |    Sensitive:  0         
--------------------------+-------------------------------------------------
Changes (by jinmei):

  * owner:  jinmei => zhanglikun


Comment:

 Replying to [comment:3 zhanglikun]:
 > Hi Jinmei, I have reviewed the change you did, thank for you fix. I find
 some functions in lib/xfr/fd_share.cc is changed like:
 > int
 > recv_fd(const int sock) {
 >    //.....
 > }
 > Is this style recommended in our document? I remember you had sent one
 email talking about this.

 I'm not sure which part of the style you're asking but please first go
 through the coding guidelines: http://bind10.isc.org/wiki/CodingGuidelines

 and if you are still not sure please ask again with clarifying exactly
 which part you don't understand.

 Oh, btw, if we follow the guideline, recv_fd would have to be recvFD or
 recvFd (maybe the former is better since "FD" is a kind of acronym).

-- 
Ticket URL: <https://bind10.isc.org/ticket/141#comment:4>
BIND 10 Development <http://bind10.isc.org>
BIND 10 Development


More information about the bind10-tickets mailing list