BIND 10 #35: review needed: configure.ac, Makefile.am and related for main level

[BIND 10 Development]

#35: review needed: configure.ac, Makefile.am and related for main level
--------------------------+-------------------------------------------------
 Reporter:  jreed         |        Owner:  jreed                                            
     Type:  task          |       Status:  assigned                                         
 Priority:  blocker       |    Milestone:  02. Running, functional authoritative-only server
Component:  Unclassified  |   Resolution:                                                   
 Keywords:  review        |    Sensitive:  0                                                
--------------------------+-------------------------------------------------
Changes (by jelte):

  * owner:  jelte => jreed


Comment:

 configure.ac:51: PYTHON_INCLUDES=`${PYTHON}-config --includes`

 I actually added a check for the existence of ${PYTHON}-config in
 experiments/python-bindings r1715 (where I also added the check for
 Python.h which that branch needs); on most linux systems, most packages
 are split between a runtime and a development package, and the latter
 is usually not installed by default (named <package>-dev in most cases).
 In this specific case, python3-dev provides the python3-config tool,
 and currently this configure code results in a warning that the tool
 could not be found which is easily missed. We should probably merge
 back that specific change. I'll fix the conflict that we get if we
 later merge back experiments/python-bindings :)

 +if test ! -x ${PYTHON}-config; then
 +       AC_MSG_ERROR([${PYTHON}-config not found])
 +fi

 Should we consider moving our specific configure functions into a
 included m4 file? (at Labs we used a shared acx_nlnetlabs.m4 file, for
 two reasons, one might not be relevant for us and that is that we
 shared a lot of functions between different projects, but the other
 was to keep the main configure.ac more readable).

 Another change we discussed yesterday is to fail by default if the
 correct boost-python library cannot be found (and add a flag to
 specifically disable that, so that the person who builds it knows
 that the xfrs won't work for them).

 Another thing, and that might be me, and it is probably more of a
 documentation thing (should at least go into both the guide and the
 README, is what our different configure flags do exactly, mainly
 the several --with-boost-XXX flags are not quite clear. I think one
 of them (--with-boost-system) is also not described in the user
 guide right now.

 Makefiles look fine to me.

-- 
Ticket URL: <https://bind10.isc.org/ticket/35#comment:2>
BIND 10 Development <http://bind10.isc.org>
BIND 10 Development