BIND 10 #38: review: src/bin/cfgmgr

BIND 10 Development do-not-reply at isc.org
Sun Apr 18 11:30:09 UTC 2010


#38: review: src/bin/cfgmgr
--------------------------+-------------------------------------------------
 Reporter:  jreed         |        Owner:  shane                                            
     Type:  task          |       Status:  assigned                                         
 Priority:  blocker       |    Milestone:  02. Running, functional authoritative-only server
Component:  Unclassified  |   Resolution:                                                   
 Keywords:  review        |    Sensitive:  0                                                
--------------------------+-------------------------------------------------

Comment(by mgraff):

 I forgot to include the C++ review here.  Ooops.

 The comments need to be changed in the header and perhaps .cc files.  It
 is extremely difficult to read this:

   // Returns the local (...)
   void someFunciton() { ... }
   // comment here
   void functionHere();
   // comment here

 Put spaces to make it easier to match comments with the item they apply to
 by quick glance.

 Nice test coverage here too.

-- 
Ticket URL: <https://bind10.isc.org/ticket/38#comment:5>
BIND 10 Development <http://bind10.isc.org>
BIND 10 Development


More information about the bind10-tickets mailing list