BIND 10 #20: review Element class

BIND 10 Development do-not-reply at isc.org
Sun Apr 18 11:40:39 UTC 2010


#20: review Element class
----------------------------------------+-----------------------------------
 Reporter:  jelte                       |        Owner:  jelte                                                
     Type:  task                        |       Status:  assigned                                             
 Priority:  major                       |    Milestone:  01. Running, non-functional authoritative-only server
Component:  Inter-module communication  |   Resolution:                                                       
 Keywords:  ccapi                       |    Sensitive:  0                                                    
----------------------------------------+-----------------------------------
Changes (by mgraff):

  * owner:  mgraff => jelte


Comment:

 I question the factory functions.  I know they are intended to make them
 exception-free by catching the memory allocation failure and returning an
 empty element, but I think this will cause problems.  If every method that
 calls this isn't careful it will send badly formatted messages in the case
 where memory allocation fails.  Isn't it just better to let the
 application deal with out of memory, perhaps at a higher, request-level
 event rather than having to validate the return of a factory?

 As a general comment, I think we need to re-visit if we need all the
 specific types for integer, decimal, etc.  I know C++ is strongly typed,
 but we can also specify data types and ranges in the messages we send
 (documentation good!) and check for those based on received format.  In
 other words, do we really need anything more than the basic 4 types:

   hash, array, number, string?

-- 
Ticket URL: <http://bind10.isc.org/ticket/20#comment:6>
BIND 10 Development <http://bind10.isc.org>
BIND 10 Development


More information about the bind10-tickets mailing list