BIND 10 #94: review: truncation support in the DNS message library

[BIND 10 Development]

#94: review: truncation support in the DNS message library
---------------------------+------------------------------------------------
 Reporter:  jinmei         |        Owner:  jinmei                       
     Type:  task           |       Status:  closed                       
 Priority:  blocker        |    Milestone:  03. Authoritative-only server
Component:  DNSPacket API  |   Resolution:  fixed                        
 Keywords:                 |    Sensitive:  0                            
---------------------------+------------------------------------------------
Changes (by jinmei):

  * status:  assigned => closed
  * resolution:  => fixed


Comment:

 Replying to [comment:4 jelte]:
 > So apart from replacing that non-local static by fixed arrays for
 digitvalue and maptolower the changes are only in the throw() statements?

 Yes, and one more minor point: removed unnecessary const from the return
 type (when an object is returned):

 -    const uint8_t at(size_t pos) const
 +    uint8_t at(size_t pos) const

 > Both of these look good, although the documentation for Name(Buffer) has
 not been updated.

 Okay, thanks.  And the doc error was fixed in r1736.

 > I have not checked the exception catching in calling functions, if this
 is needed to, I will.

 Do you mean other than unittests?  If so, no I don't think you need to
 check them.

 Thanks for the review.  Closing ticket.

-- 
Ticket URL: <http://bind10.isc.org/ticket/94#comment:5>
BIND 10 Development <http://bind10.isc.org>
BIND 10 Development