BIND 10 #115: review: move UNUSED_PARAM to .cc

[BIND 10 Development]

#115: review: move UNUSED_PARAM to .cc
--------------------------+-------------------------------------------------
 Reporter:  jinmei        |        Owner:  jelte   
     Type:  enhancement   |       Status:  assigned
 Priority:  minor         |    Milestone:          
Component:  Unclassified  |   Resolution:          
 Keywords:                |    Sensitive:  0       
--------------------------+-------------------------------------------------
Changes (by jinmei):

  * owner:  jinmei => jelte


Comment:

 Replying to [comment:3 jelte]:
 > another change sneaked in that patch (data_source.cc:905: replaced
 pointer to array by pointer to its first element) :)

 Ah, yes, good catch.  And, in fact, this change does more than the above:
 avoiding the use intermediate plain old array.  The behavior should be the
 same, but as indicated by the patch I believe the revised code is much
 simpler (and, although the purpose of the patch was not for efficiency,
 should be a bit faster).

 I could file a separate review request just for this, but is it okay for
 you to look at this part, too?

 > oh and another one, isc/cc/data.cc has its contents in an unnamed
 namespace now, which in itself is good, though i'm wondering if we might
 ever need PROTOCOL_VERSION outside of this file. We might need to ask
 Michael about this.

 Ah, another good point.  But in that case PROTOCOL_VERSION would be too
 generic even if it would be in the isc::data namespace.

 This comment reminds me of one thing I've been wondering.  The protocol
 version reads 'Skan'.  I know what it comes from, and perhaps it's
 beneficial in that we fill in all of the 4 octets with non trivial values
 (like zero) for debugging purposes, but I suspect it still looks awkward
 for others (it actually looks like a "magic number" rather than a
 "version") and might confuse them.  Now that we've confirmed the module is
 working to some extent, wouldn't it be the time to use a more natual value
 for a "version number"?  (I guess the question should go to Michael or
 even to the -dev list, though)

 > UNUSED_PARAM changes are good, i'll drop a line to -dev about this.

 Okay, thanks.

-- 
Ticket URL: <https://bind10.isc.org/ticket/115#comment:4>
BIND 10 Development <http://bind10.isc.org>
BIND 10 Development