BIND 10 #216: Xfrin: Implement the feature items in TODO file.

[BIND 10 Development]

#216: Xfrin: Implement the feature items in TODO file.
------------------------------+---------------------------------------------
      Reporter:  zhanglikun   |        Owner:  shentingting        
          Type:  enhancement  |       Status:  reviewing           
      Priority:  major        |    Milestone:  feature backlog item
     Component:  xfrin        |   Resolution:                      
      Keywords:               |    Sensitive:  0                   
Estimatedhours:  0.0          |        Hours:                      
      Billable:  1            |   Totalhours:                      
      Internal:  0            |  
------------------------------+---------------------------------------------
Changes (by jinmei):

  * owner:  zhanglikun => shentingting


Comment:

 - It doesn't pass tests at least in my environment (see the end of this
 message).  Please fix them first.
  - As for the coverage, 91% of xfrin.py is covered in the current trunk.
 If it decreased to 80% in this patch that wouldn't be good.
  - A minor editorial nit.  There's an awkward line currently commented
 out.  If it's not necessary, please remove it.  If it plans to be
 completed but cannot be so for some reason right now, please clarify that
 in a comment.
 {{{
 +    def test_connect(self):
 +        #self.assertEqual(, "")
 }}}
  - Another minor editorial nit in the !ChangeLog entry.  I've directly
 fixed it in the branch (r2644)

 {{{
 Making check in tests
 make  check-local
 for pytest in xfrin_test.py ; do \
         echo Running test: $pytest ; \
         env
 PYTHONPATH=/Users/jinmei/src/isc/bind10/branches/trac216/src/lib/dns/.libs:/Users/jinmei/src/isc/bind10/branches/trac216/src/lib/dns/python/.libs:/Users/jinmei/src/isc/bind10/branches/trac216/src/bin/xfrin:/Users/jinmei/src/isc/bind10/branches/trac216/src/lib/python:/Users/jinmei/src/isc/bind10/branches/trac216/src/lib/python
 \
         /opt/local/bin/python3.1
 /Users/jinmei/src/isc/bind10/branches/trac216/src/bin/xfrin/tests/$pytest
 ; \
         done
 Running test: xfrin_test.py
 .[b10-xfrin] test error
 [b10-xfrin] Error happened! is the command channel daemon running?
 .[b10-xfrin] test exception
 .[b10-xfrin] exit b10-xfrin
 ....E.E.....................................
 ======================================================================
 ERROR: test_command_handler_retransfer_inprogress (__main__.TestXfrin)
 ----------------------------------------------------------------------
 Traceback (most recent call last):
   File
 "/Users/jinmei/src/isc/bind10/branches/trac216/src/bin/xfrin/tests/xfrin_test.py",
 line 453, in test_command_handler_retransfer_inprogress
     self.xfr._zones[TEST_ZONE_NAME] = MockThread()
 AttributeError: 'MockXfrin' object has no attribute '_zones'

 ======================================================================
 ERROR: test_command_handler_retransfer_quota (__main__.TestXfrin)
 ----------------------------------------------------------------------
 Traceback (most recent call last):
   File
 "/Users/jinmei/src/isc/bind10/branches/trac216/src/bin/xfrin/tests/xfrin_test.py",
 line 442, in test_command_handler_retransfer_quota
     self.xfr._zones[str(i) + TEST_ZONE_NAME] = MockThread()
 AttributeError: 'MockXfrin' object has no attribute '_zones'

 ----------------------------------------------------------------------
 Ran 47 tests in 0.084s

 FAILED (errors=2)
 make[2]: *** [check-local] Error 1
 make[1]: *** [check-am] Error 2
 make: *** [check-recursive] Error 1
 }}}

-- 
Ticket URL: <http://bind10.isc.org/ticket/216#comment:7>
BIND 10 Development <http://bind10.isc.org>
BIND 10 Development