BIND 10 #216: Xfrin: Implement the feature items in TODO file.

[BIND 10 Development]

#216: Xfrin: Implement the feature items in TODO file.
------------------------------+---------------------------------------------
      Reporter:  zhanglikun   |        Owner:  shentingting        
          Type:  enhancement  |       Status:  reviewing           
      Priority:  major        |    Milestone:  feature backlog item
     Component:  xfrin        |   Resolution:                      
      Keywords:               |    Sensitive:  0                   
Estimatedhours:  0.0          |        Hours:                      
      Billable:  1            |   Totalhours:                      
      Internal:  0            |  
------------------------------+---------------------------------------------

Comment(by jinmei):

 Replying to [comment:8 shentingting]:
 > I am very sorry! I forgot to change xfrin_test.py after I changed a
 variable name
 >
 > from self._zones to self._threads_zones. Now, it works well!

 Okay, thanks.

 Before performing full review, however, please improve test coverage:

  - !XfrinConnection.send/recv/_loop/close must be tested using an
 apprproiate mock.  The current trunk version of xfrin does that.  See also
 xfrout.  It uses a mock Socket class for testing.
  - Likewise, in Xfrin._cc_setup we should check config_data is correctly
 handled (you'll probably need a mock version of ModuleCCSession).

 Other things I noted:
  - please also fixed the editorial issue I mentioned in my previous
 comment
  - why did we switch from asyncore to select?  I don't know this migration
 is inevitable or a good idea, but in any case such a design decision
 should be documented.

-- 
Ticket URL: <http://bind10.isc.org/ticket/216#comment:9>
BIND 10 Development <http://bind10.isc.org>
BIND 10 Development