BIND 10 #268: review: setuid via -u on b10-auth

[BIND 10 Development]

#268: review: setuid via -u on b10-auth
------------------------------+---------------------------------------------
      Reporter:  shane        |        Owner:  jelte                      
          Type:  enhancement  |       Status:  reviewing                  
      Priority:  major        |    Milestone:  06. 4th Incremental Release
     Component:  b10-auth     |   Resolution:                             
      Keywords:               |    Sensitive:  0                          
Estimatedhours:  0.0          |        Hours:  0                          
      Billable:  1            |   Totalhours:  1.0                        
      Internal:  0            |  
------------------------------+---------------------------------------------
Changes (by jinmei):

  * owner:  jinmei => jelte


Comment:

 Replying to [comment:11 jelte]:
 > I think this is ok and can be merged.
 >
 > One minor nit/question;
 >
 > In the last unit test, should we try to check for uid, not username?
 (not sure what USER is set to if you have a second superuser. If this is
 still root there's no problem. On some OS'es i think there are even other
 ways to be a superuser, but this whole problem may be gone before we
 encounter that anyway, if ever)
 >
 Do you mean it's better to do this?
 {{{
     if (getuid() == 0) {
         cerr << "Already a super user, skipping the test" << endl;
         return;
     }
 }}}

 I'm okay with that, although it may cause another question that we can
 always assume the user ID of 0 means a super user (or does the standard
 reserve this ID for this purpose?).

 BTW, I've added some comments based on my previous respnse to Shane.  It's
 r2667.

-- 
Ticket URL: <http://bind10.isc.org/ticket/268#comment:13>
BIND 10 Development <http://bind10.isc.org>
BIND 10 Development