BIND 10 #260: More suggestions to bindctl

[BIND 10 Development]

#260: More suggestions to bindctl
------------------------------+---------------------------------------------
      Reporter:  shane        |        Owner:  shentingting        
          Type:  enhancement  |       Status:  reviewing           
      Priority:  minor        |    Milestone:  feature backlog item
     Component:  bind-ctl     |   Resolution:                      
      Keywords:               |    Sensitive:  0                   
Estimatedhours:  0.0          |        Hours:                      
      Billable:  1            |   Totalhours:                      
      Internal:  0            |  
------------------------------+---------------------------------------------

Comment(by shentingting):

 Hello jelte:
    I changed it again. Change a 'except Exception' to specific exception.
 So please help me review it again. If it is OK, please help me merge it
 into trunk. Thanks.


 Replying to [comment:5 jelte]:
 > One error; the last change there prints 'err' but the variable name of
 the exception is 'e'. Other than that this fix looks fine.
 >
 > but, this also shows my original problem (which it does not fix), which
 is in bindctl-source.py.in; there's a statement 'except Exception' there,
 and while nice for users, it's a problem for developers since the printed
 message there does not show *where* the error occurred.
 >
 > I agree with Shane that we should not show users stacktraces, but we (as
 developers) certainly need them. I think we *should* print full
 stacktraces for problems we really do not expect (i.e. the places we put a
 catch-all like 'except Exception'). And we should not get there for
 problems we do anticipate (like the user-friendly changes made above,
 which I approve).
 >
 > Best of both worlds may be do a full stacktrace, only in the catch-all,
 and only if verbose is set (though there is no verbose option right now,
 it should be easy to add)

-- 
Ticket URL: <http://bind10.isc.org/ticket/260#comment:6>
BIND 10 Development <http://bind10.isc.org>
BIND 10 Development