BIND 10 #283: Xfrout uses different socket file than b10-auth when ran from source

[BIND 10 Development]

#283: Xfrout uses different socket file than b10-auth when ran from source
-------------------------+--------------------------------------------------
      Reporter:  jreed   |        Owner:  jelte    
          Type:  defect  |       Status:  reviewing
      Priority:  major   |    Milestone:           
     Component:  xfrout  |   Resolution:           
      Keywords:          |    Sensitive:  0        
Estimatedhours:  0.0     |        Hours:           
      Billable:  0       |   Totalhours:           
      Internal:  0       |  
-------------------------+--------------------------------------------------
Changes (by jinmei):

  * owner:  => jelte
  * status:  new => reviewing


Comment:

 Replying to [comment:4 jelte]:
 > The issue here is another one than the one in #299; it's a regression as
 a result from the changes in changelog item 79 (trac #221, r2565);
 >
 > (btw, no the socket file should not be changeable by the user, but if we
 want to run from source we can't rely on having access to whatever is the
 target directory)
 >
 > this should fix it:

 It basically looks okay.  Some minor points:

  - I'd avoid specifying the redundant std:: when we say 'using namespace
 std'.  at least the policy isn't consistent with other cases of this file.
 >
 {{{
 +    std::string xfrout_socket_path;
 }}}
  - I'd not rely on automatic conversion from a pointer to bolean:
 {{{
 +    if (getenv("B10_FROM_BUILD")) {
 }}}
   so, it should be:
 {{{
 +    if (getenv("B10_FROM_BUILD") != NULL) {
 }}}
  - maybe we want to remember getenv("B10_FROM_BUILD") somewhere and use it
 in the rest of the code:
 {{{
     const char* ev_from_build = getenv("B10_FROM_BUILD");
     if (ev_from_build != NULL) {
         ....
 }}}
  - technically, we'd avoid letting string generation throw an exception
 and force the program terminate abruptly.  but that also applies to the
 construction of !XfroutClient, so we should probably just live with it at
 least for now.

-- 
Ticket URL: <http://bind10.isc.org/ticket/283#comment:5>
BIND 10 Development <http://bind10.isc.org>
BIND 10 Development