BIND 10 #296: Timeouts on msgq's cc-channel

[BIND 10 Development]

#296: Timeouts on msgq's cc-channel
-------------------------------+--------------------------------------------
      Reporter:  jelte         |        Owner:  jinmei              
          Type:  enhancement   |       Status:  reviewing           
      Priority:  major         |    Milestone:  y2 6 month milestone
     Component:  Unclassified  |   Resolution:                      
      Keywords:                |    Sensitive:  0                   
Estimatedhours:  0.0           |        Hours:  0                   
      Billable:  1             |   Totalhours:  0                   
      Internal:  0             |  
-------------------------------+--------------------------------------------
Changes (by jelte):

  * owner:  jelte => jinmei


Comment:

 Adressed all the minor issues in r2699;

 (note; for the unlink in test I made a SessionTest class; which contains a
 pointer to the TestDomainSocket class; this is because we need to unlink
 before we initialize it, so it can't be done with a member initializer. I
 briefly entertained to make a 'reverse file holder' class, that is empty
 except for a constructor that calls unlink(), but that was too uglyfor me
 :))

 About the namespace, we do use it somewhere else; in the class inheritance
 definition of the classes we use in TEST_F. But i've removed the one from
 unlink. (second one also removed in r2701)

 Lastly, the int size thing; yes you are right, I could add it to this one
 (but have not yet), but we could also make it another ticket (not sure if
 there are other places where this comes up)

 Oh and i found another problem in cfgmgr.py; with the current way the
 timeouts are handled, it should not exit if group_recvmsg() returns None
 (r2700)


 About the setResult function. I don't think it can actually happen in
 practice, since either the timer expires, in which case the async_read()
 is canceled, or async_read returns an error, in which case the timer is
 canceled, so after this method exits there should be no pending actions
 that result in callbacks.

 However, if we are uncomfortable with it; i did commit a change that makes
 it use member variables (and two setResult functions instead of 1); r2702.
 Though i'm actually not at all sure whether this is better.

-- 
Ticket URL: <https://bind10.isc.org/ticket/296#comment:10>
BIND 10 Development <http://bind10.isc.org>
BIND 10 Development