BIND 10 #296: Timeouts on msgq's cc-channel
BIND 10 Development
do-not-reply at isc.org
Tue Aug 17 16:54:57 UTC 2010
#296: Timeouts on msgq's cc-channel
-------------------------------+--------------------------------------------
Reporter: jelte | Owner: jinmei
Type: enhancement | Status: reviewing
Priority: major | Milestone: y2 6 month milestone
Component: Unclassified | Resolution:
Keywords: | Sensitive: 0
Estimatedhours: 0.0 | Hours: 0
Billable: 1 | Totalhours: 0
Internal: 0 |
-------------------------------+--------------------------------------------
Comment(by jinmei):
Replying to [comment:17 jelte]:
I think the latest branch is okay to merge.
Some minor, non blocking comments follow. These can be ignored.
- I made a trivial editorial fix in the branch (r2754)
- As for the idea of the implication of not setting timeout after
starting, I was aware of that. But I thought it could be an acceptable
workaround in that we can at least notice bootstrap time failures quite
soon. Once the whole BIND 10 service starts successfully and then a CC
session stalls, I suspect we'll end up kill everything anyway (at least
for now). In any event, I see the revised code is better than that.
- To be very precise, the following comment in r2752...
{{{
// asio::error_code evaluates to false if there was no error
}}}
...should be
{{{
// asio::error_code evaluates to true if there was an error
}}}
because the type conversion operator only says the latter. The former
comment is also true with the understanding that the negation of "if a
boolean value is not true it must be true" and "the negation of there is
an error is there is no error", but one needs to run this logic to reach
this conclusion (even if it's pretty trivial).
--
Ticket URL: <http://bind10.isc.org/ticket/296#comment:18>
BIND 10 Development <http://bind10.isc.org>
BIND 10 Development
More information about the bind10-tickets
mailing list