BIND 10 #317: suggested cleanups for the python bindings of libdns++

BIND 10 Development do-not-reply at isc.org
Tue Aug 24 23:38:32 UTC 2010


#317: suggested cleanups for the python bindings of libdns++
--------------------------------+-------------------------------------------
      Reporter:  jinmei         |        Owner:  jinmei              
          Type:  enhancement    |       Status:  new                 
      Priority:  minor          |    Milestone:  y2 6 month milestone
     Component:  DNSPacket API  |   Resolution:                      
      Keywords:                 |    Sensitive:  0                   
Estimatedhours:  0.0            |        Hours:  0                   
      Billable:  1              |   Totalhours:  0                   
      Internal:  0              |  
--------------------------------+-------------------------------------------

Comment(by jinmei):

 One more point:

 I suspect we should catch error cases in !PyInit_libdns_python() and react
 accordingly (return NULL, probably).

 For example, I guess !PyErr_NewException() could fail here:
 {{{
     po_IscException = PyErr_NewException("libdns_python.IscException",
 NULL, NULL);
 }}}
 (although the python manual doesn't say anything about failure
 cases...which is bad)

 Same for !PyModule_AddObject:

 {{{
     PyModule_AddObject(mod, "IscException", po_IscException);
 }}}

-- 
Ticket URL: <http://bind10.isc.org/ticket/317#comment:3>
BIND 10 Development <http://bind10.isc.org>
BIND 10 Development


More information about the bind10-tickets mailing list