BIND 10 #310: proposal: constify lib/cc API more appropriately

[BIND 10 Development]

#310: proposal: constify lib/cc API more appropriately
--------------------------------+-------------------------------------------
      Reporter:  jinmei         |        Owner:  jinmei              
          Type:  enhancement    |       Status:  reviewing           
      Priority:  minor          |    Milestone:  y2 6 month milestone
     Component:  configuration  |   Resolution:                      
      Keywords:                 |    Sensitive:  0                   
Estimatedhours:  0.0            |        Hours:  3                   
      Billable:  1              |   Totalhours:  5.0                 
      Internal:  0              |  
--------------------------------+-------------------------------------------
Changes (by jelte):

  * hours:  0.0 => 3.0
  * owner:  jelte => jinmei
  * totalhours:  5.0 => 8.0


Comment:

 Minor style issue discussed on jabber, committed fix in r2800

 I disagree with the statement that the Element API is complicated (unless
 you are talking about the ccsession/modulespec api) btw :p

 Anyhew, apart from the minor style thing I have no substantial problems
 with these changes.

 Two things though; The operator overrides using ElementPtr instead of
 Element were intentional, since users of this API should only be working
 with Ptr's anyway, and to me it looks better to use them directly (compare
 the changed test cases for instance). However I don't have a strong
 opinion on this.

 Secondly, I do worry a bit about the now-introduced copy overhead (which
 was why the merge etc were done in-place). But I acknowledge the added
 safety. So for now I think this is ok. At some point in the future we
 might need to consider having non-const versions of some methods, but we'd
 need to profile those cases when they arise, and for the near future I see
 no problems with them, and

 I think this is ok to commit.

-- 
Ticket URL: <http://bind10.isc.org/ticket/310#comment:3>
BIND 10 Development <http://bind10.isc.org>
BIND 10 Development