BIND 10 #216: Xfrin: Implement the feature items in TODO file.

[BIND 10 Development]

#216: Xfrin: Implement the feature items in TODO file.
------------------------------+---------------------------------------------
      Reporter:  zhanglikun   |        Owner:  jinmei              
          Type:  enhancement  |       Status:  reviewing           
      Priority:  major        |    Milestone:  y2 6 month milestone
     Component:  xfrin        |   Resolution:                      
      Keywords:               |    Sensitive:  0                   
Estimatedhours:  0.0          |        Hours:                      
      Billable:  1            |   Totalhours:                      
      Internal:  0            |  
------------------------------+---------------------------------------------

Comment(by jinmei):

 I'm reviewing the branch.  It's not completed yet, but I'd like to provide
 some initial feedback on the usage of select.select.

  - the test (test_loop) doesn't actually seem to test what is to be
 tested.  with this test select.select returns simply because the mock
 socketpair[0] is closed right after setUp().  we should actually test the
 cases where
   - select returns successfully with data
   - select timeouts
   - select returns due to a shutdown message
  - method names "loop" is now misleading because we switched the API
  - we could avoid having a separate "callback" method for recv after
 select, that is, handle_read().  in fact, according to the background
 reason for the switch, it would be better to unify the select+read logic
 as much as possible, as long as we can perform sufficient tests.
  - the current code returns if select fails due to EINTR.  is that the
 intentional behavior?  the convention in this case (as far as I know) is
 to ignore EINTR and continue the select until a required event happens or
 select timeouts.

 I've committed a proposed change to address these points (with other
 cleanups) to the branch.  It's r2807.  Please check it.

-- 
Ticket URL: <http://bind10.isc.org/ticket/216#comment:17>
BIND 10 Development <http://bind10.isc.org>
BIND 10 Development