BIND 10 #347: Implement query counters in auth module

[BIND 10 Development]

#347: Implement query counters in auth module
------------------------------+---------------------------------------------
      Reporter:  naokikambe   |        Owner:  jinmei               
          Type:  enhancement  |       Status:  reviewing            
      Priority:  major        |    Milestone:  y2 12 month milestone
     Component:  b10-auth     |   Resolution:                       
      Keywords:               |    Sensitive:  0                    
Estimatedhours:  0.0          |        Hours:  0                    
      Billable:  1            |   Totalhours:  0                    
      Internal:  0            |  
------------------------------+---------------------------------------------
Changes (by y-aharen):

  * owner:  naokikambe => jinmei


Comment:

 Jinmei-san, thank you very much for your review. Before fixing the code
 and committing to branch, I have few points to be clear.

 Replying to [comment:5 jinmei]:
 > '''stats.cc'''
 >   - The comment and log messages assume that the other end is the
 >     b10-stats program, but interface-wise it's not necessarily correct
 >     (that could be a third-party app that implements the stat API,
 >     right?)
 Counter in Auth module is not intended to communicate with third-party
 stats module. It only communicates with b10-stats.

 >   - BTW, even if it doesn't cause timeout and exception, we should
 >     actually not even block in group_recvmsg (and also
 >     group_sendmsg(), which can happen because it's a connected
 >     channel): b10-auth shouldn't stop handling DNS queries even for 1
 >     second.  Since it should relatively a rare event we can live with
 >     the current blocking mode (and there are actually other parts of
 >     b10-auth that have the same problem).  But please leave a TODO
 >     comment on this point.  We should eventually solve it.
 I don't think that blocking in group_{send,recv}msg also blocks handling
 of DNS queries. I understand blocking read/write operation stops in the
 ASIO library, and if another event arrives ASIO starts handling it. Excuse
 me if I misunderstood.

-- 
Ticket URL: <http://bind10.isc.org/ticket/347#comment:8>
BIND 10 Development <http://bind10.isc.org>
BIND 10 Development