BIND 10 #415: new query logic for in memory data source (1)

[BIND 10 Development]

#415: new query logic for in memory data source (1)
---------------------------+------------------------------------------------
      Reporter:  jinmei    |        Owner:  jinmei               
          Type:  task      |       Status:  reviewing            
      Priority:  major     |    Milestone:  y2 12 month milestone
     Component:  b10-auth  |   Resolution:                       
      Keywords:            |    Sensitive:  0                    
Estimatedhours:  0.0       |        Hours:  0                    
      Billable:  1         |   Totalhours:  0                    
      Internal:  0         |  
---------------------------+------------------------------------------------
Changes (by jelte):

  * owner:  jelte => jinmei


Comment:

 I don't have an overview of the entire design and where it fits in (and
 comment on that would be out of scope for this ticket anyway), so i'll
 keep it localized;

 I only have a few questions/comments, nothing really source code-related
 (that looks ok)

 - This introduces a second Query class, under a different namespace. Is it
 supposed to replace the one under datasrc::? I know that that is what
 namespaces are for, but we tend to use 'using namespace' (which itself i
 don't really like anyway, btw), and the potential confusion does worry me
 a bit.

 - note: If I read this correctly, the Rcode that would in the end be set
 by this code for data that is not found changes from current behaviour
 (right now it returns REFUSED, not SERVFAIL). I prefer this new one (and
 do REFUSED because of ACL, not data presence) :)

 - One of the example for future changes in the comments say that we may
 consider returning the Rcode instead of setting it in the provided
 response message. If the process() function is going to modify the
 response by adding results anyway, i think we should also set the Rcode in
 it. We can then still decide to also return it (or a different simple
 value that represents success/error)

 As said, I think the rest looks ok.

-- 
Ticket URL: <http://bind10.isc.org/ticket/415#comment:3>
BIND 10 Development <http://bind10.isc.org>
BIND 10 Development