BIND 10 #405: basic support for addressing individual list items in configuration

[BIND 10 Development]

#405: basic support for addressing individual list items in configuration
--------------------------------+-------------------------------------------
      Reporter:  jelte          |        Owner:  jelte    
          Type:  defect         |       Status:  reviewing
      Priority:  major          |    Milestone:           
     Component:  configuration  |   Resolution:           
      Keywords:                 |    Sensitive:  0        
Estimatedhours:  0.0            |        Hours:  0        
      Billable:  1              |   Totalhours:  0        
      Internal:  0              |  
--------------------------------+-------------------------------------------
Changes (by stephen):

  * owner:  stephen => jelte


Comment:

 '''src/lib/python/isc/cc/data.py'''[[BR]]
 In find():
 {{{
     if (type(element) != dict and identifier != ""):
         raise DataTypeError("element in find() is not a dict")
 }}}
 The error message will not be output if identifier is the empty string.

 '''src/lib/python/isc/config/ccsession.py'''
 In remove_value(), would like to see some comment as to why:[[BR]]
 {{{
         if identifier == "":
             identifier = value_str
             value_str = None
 }}}
 ... is necessary as it means that xxx.remove_value("", "xyz") is the same
 as xxx.remove_value("xyz", None).  Why the two forms of the call?

 '''src/lib/python/isc/config/tests/ccsession_test.py'''[[br]]
 In test_add_remove_value:
 {{{
         uccs.remove_value("Spec2/item5[0]", None)
         self.assertEqual({'Spec2': {'item5': []}}, uccs._local_changes)
         uccs.remove_value("", "Spec2/item5[0]")
         self.assertEqual({'Spec2': {'item5': []}}, uccs._local_changes)
 }}}
 The second remove_value() test does not check that it has the same effect
 as the first one, it only checks that it has no effect on the data - is
 that what is required?

-- 
Ticket URL: <http://bind10.isc.org/ticket/405#comment:3>
BIND 10 Development <http://bind10.isc.org>
BIND 10 Development