BIND 10 #397: Port generic red-black tree (RBT) data structure from BIND-9

[BIND 10 Development]

#397: Port generic red-black tree (RBT) data structure from BIND-9
------------------------------+---------------------------------------------
      Reporter:  zzchen_pku   |        Owner:  jinmei   
          Type:  enhancement  |       Status:  reviewing
      Priority:  major        |    Milestone:           
     Component:  data source  |   Resolution:           
      Keywords:               |    Sensitive:  0        
Estimatedhours:  0.0          |        Hours:  0        
      Billable:  1            |   Totalhours:  0        
      Internal:  0            |  
------------------------------+---------------------------------------------

Comment(by jinmei):

 Replying to [comment:23 hanfeng]:

 > > A quick check: the response doesn't seem to cover all of the review
 comments.  Does that mean you are still working on other comments, or does
 that mean you simply adopted the review suggestions?
 > I think i covered all the comments, except the following two points:
 > 1 Add more documentation for different kind of user
 > 2 Function rename like copyDNSData
 > I am still working on them. The comment is really huge, so if I miss
 anything, please tell me, I will fix them ASAP.
 >
 Actually there seem to be several open points (I'll send them separately).

 It was also not clear whether the introduction of iterator was needed to
 solve a problem of the original code or was rather a new feature.  We
 shouldn't include a new feature into such an already big ticket - it
 should go to a separate task.  I'm sorry if I was not clear on this point
 in my previous comments.  I intended to mean so by this comment:
   - we may eventually want to introduce an iterator, and want to have
     insert() return an iterator.  for now I'm okay without this
     extension, but it would be better to note this possibility in the
     class documentation.

 Anyway: for this sprint, we only need a much smaller subset of the feature
 we're currently having.  Specifically:
  - create the table
  - insert entries
  - find a longest match entry

 We don't need to erase entries; we don't need iterators.  Can we focus on
 a subset of this branch that only covers the 3 crucial points?  It will
 help complete the review process faster and give us time to work on other
 tasks.  The rest of the features/code will be a subject of future sprints.

-- 
Ticket URL: <http://bind10.isc.org/ticket/397#comment:24>
BIND 10 Development <http://bind10.isc.org>
BIND 10 Development