BIND 10 #356: Resolver address database
BIND 10 Development
do-not-reply at isc.org
Tue Dec 7 17:30:45 UTC 2010
#356: Resolver address database
-------------------------------+--------------------------------------------
Reporter: stephen | Owner: ocean
Type: enhancement | Status: reviewing
Priority: major | Milestone:
Component: Unclassified | Resolution:
Keywords: | Sensitive: 0
Estimatedhours: 0.0 | Hours: 0
Billable: 1 | Totalhours: 0
Internal: 0 |
-------------------------------+--------------------------------------------
Changes (by stephen):
* owner: stephen => ocean
Comment:
I've looked at the differences between the current head (r3754) and the
last reviewed revision (r3706).
'''src/lib/nsas/tests/random_number_generator_unittest.cc'''[[BR]]
It would be worth adding a comment for future maintainers to explain the
{{{#ifndef NDEBUG}}} brackets.
'''src/lib/nsas/nameserver_entry.cc'''[[BR]]
''NameserverEntry::updateAddressSelector'':
{{{
if(rtt == 0) isc_throw(RTTIsZero, "The RTT is 0");
}}}
The "isc_throw" should be in braces.
If all the nameservers are unreachable, all probabilities will be set to
0. This will lead to an attempt to calculate 0/0 during normalisation
which will most likely generate a floating point error.
--
Ticket URL: <http://bind10.isc.org/ticket/356#comment:17>
BIND 10 Development <http://bind10.isc.org>
BIND 10 Development
More information about the bind10-tickets
mailing list