BIND 10 #397: Port generic red-black tree (RBT) data structure from BIND-9
BIND 10 Development
do-not-reply at isc.org
Fri Dec 10 01:40:04 UTC 2010
#397: Port generic red-black tree (RBT) data structure from BIND-9
------------------------------+---------------------------------------------
Reporter: zzchen_pku | Owner: jinmei
Type: enhancement | Status: reviewing
Priority: major | Milestone:
Component: data source | Resolution:
Keywords: | Sensitive: 0
Estimatedhours: 0.0 | Hours: 0
Billable: 1 | Totalhours: 0
Internal: 0 |
------------------------------+---------------------------------------------
Comment(by jinmei):
deleteHelper() leaks memory, and re-introduces efficient loop.
As for memory leak, I'd suggest adding an assertion in the destructor:
{{{
template <typename T>
RBTree<T>::~RBTree() {
deleteHelper(root_);
assert(node_count_ == 0);
}
}}}
(or having explicit tests, which is better but doesn't seem to be trivial)
--
Ticket URL: <http://bind10.isc.org/ticket/397#comment:32>
BIND 10 Development <http://bind10.isc.org>
BIND 10 Development
More information about the bind10-tickets
mailing list