BIND 10 #327: early work on recursion

[BIND 10 Development]

#327: early work on recursion
---------------------------+------------------------------------------------
      Reporter:  each      |        Owner:  each                 
          Type:  defect    |       Status:  reviewing            
      Priority:  major     |    Milestone:  y2 12 month milestone
     Component:  recurser  |   Resolution:                       
      Keywords:            |    Sensitive:  0                    
Estimatedhours:  0.0       |        Hours:  0                    
      Billable:  1         |   Totalhours:  0                    
      Internal:  0         |  
---------------------------+------------------------------------------------

Comment(by stephen):

 I've reviewed the files allocated to me in the attachment
 [attachment:trac327_review.txt trac327_review.txt] in r3791 of the #327
 branch and have the following comments:

 '''src/lib/asiolink/asiolink.cc'''[[BR]]
 ''class !RunningQuery''[[BR]]
 Don't understand the FIXME comment.

 '''src/lib/asiolink/asiolink.h'''[[BR]]
 ''class DNSService''[[BR]]
 This is a fairly important class, so a bit more detail in the header would
 be useful, as well as a stress on its importance.  For example, the
 DNSService also handles configuration channel messages and is the core of
 the recursor.

 ''class DNSServer''[[BR]]
 The header should note that the reason for the {{{self_}}} pointer is that
 within the Boost library an object of this class is sometimes passed by
 reference and so the derived part of the class is lost.  {{{self_}}}
 allows the subclass components to still be accessed in this case.

 ''class !AsyncLookup''[[BR]]
 Although the calling object is copied into the handler, there appears to
 be no reason why it is passed by value to the constructor rather than by
 reference.  The copy takes place when the !AsyncLookup object is
 constructed and the argument is copied into the {{{caller_}}} member, not
 during the argument passing.

 ''class !SimpleCallback''[[BR]]
 The header comment seems to be incomplete - it leads up to describing a
 function signature then omits the description.

 '''src/lib/asiolink/internal/udpdns.h'''[[BR]]
 ''class UDPServer''[[BR]]
 Needs a better class header (although there is good information within the
 class).

 ''class UDPQuery''[[BR]]
 Comment style should be consistent through the file - the rest of the file
 uses C++ comment style, this uses C-style.

 '''src/lib/datasrc/static_datasrc.cc'''[[BR]]
 ''struct !StaticDaraSrcImpl''[[BR]]
 We should include Ocean and Aharen in the list of authors.

 '''src/lib/datasrc/tests/static_unittest.cc'''[[BR]]
 Need to update the test to include Ocean and Aharen as authors.

-- 
Ticket URL: <http://bind10.isc.org/ticket/327#comment:20>
BIND 10 Development <http://bind10.isc.org>
BIND 10 Development