BIND 10 #397: Port generic red-black tree (RBT) data structure from BIND-9

BIND 10 Development do-not-reply at isc.org
Thu Dec 16 22:59:20 UTC 2010


#397: Port generic red-black tree (RBT) data structure from BIND-9
------------------------------+---------------------------------------------
      Reporter:  zzchen_pku   |        Owner:  hanfeng  
          Type:  enhancement  |       Status:  reviewing
      Priority:  major        |    Milestone:           
     Component:  data source  |   Resolution:           
      Keywords:               |    Sensitive:  0        
Estimatedhours:  0.0          |        Hours:  0        
      Billable:  1            |   Totalhours:  0        
      Internal:  0            |  
------------------------------+---------------------------------------------
Changes (by jinmei):

  * owner:  jinmei => hanfeng


Comment:

 Replying to [comment:43 hanfeng]:
 > rbtree.cc isn't in the branch and is useless, I have modified the
 Makefile.am to remove it.
 >
 Okay, I think it's now mostly ready for merge.  I've made a minor fix in
 comment wording (r3873).

 One minor suggestion: on re-reading, "NodeDataType" sounds a bit awkward
 to me.  I'd suggest changing this to, e.g., "NodeData" or "NodeDataPtr".

 And some final comments: I'd like to keep it a "hidden" backend only used
 by in memory zone and zone table implementations for now, because we defer
 some important open design related questions, including
  - reliance on boost definitions
  - class name
 "hidden" means other modules are not supposed to use this header file even
 though it's visible to them.

 If we agree, please add a note about this in comments at the beginning of
 the file.

 And one really final thing: if you want to add a changelog entry for this
 ticket, please provide proposed text.

-- 
Ticket URL: <http://bind10.isc.org/ticket/397#comment:44>
BIND 10 Development <http://bind10.isc.org>
BIND 10 Development


More information about the bind10-tickets mailing list