BIND 10 #397: Port generic red-black tree (RBT) data structure from BIND-9

BIND 10 Development do-not-reply at isc.org
Fri Dec 17 18:39:07 UTC 2010


#397: Port generic red-black tree (RBT) data structure from BIND-9
------------------------------+---------------------------------------------
      Reporter:  zzchen_pku   |        Owner:  hanfeng  
          Type:  enhancement  |       Status:  reviewing
      Priority:  major        |    Milestone:           
     Component:  data source  |   Resolution:           
      Keywords:               |    Sensitive:  0        
Estimatedhours:  0.0          |        Hours:  0        
      Billable:  1            |   Totalhours:  0        
      Internal:  0            |  
------------------------------+---------------------------------------------
Changes (by jinmei):

  * owner:  jinmei => hanfeng


Comment:

 Replying to [comment:45 hanfeng]:

 > > If we agree, please add a note about this in comments at the beginning
 of the file.
 > Note is added
 >
 I've made some suggested cleanups on the note and some other part of the
 file (r3883).  Please check.

 > > And one really final thing: if you want to add a changelog entry for
 this ticket, please provide proposed text.
 > 131.  [func]    feng
 > src/lib/datasrc: Introduced two new template classes RBTree and RBNode
 to provide
 > the generic map with domain name as key and anything as the value,
 because of
 > some unresolved design issue, the new classes is only intended to be
 used by memory zone
 > and zone table.
 > (Trac #397, svn r3736)

 Looks okay with a few nits:
  - "... the value, because of..." should be "... the value.  Because
 of...".  BTW "the comma should be a period" seems to be a common editorial
 nit in your documentation.  You may want to include this point in your
 self checklist (if any)
  - "the new classes is only..." should be "the new classes are only..."
  - svn number is the one you'll use when merging it to trunk (which is
 currently unknown).

 With these fixes (and if the suggested committed cleanups are okay) please
 merge the branch to trunk.

-- 
Ticket URL: <http://bind10.isc.org/ticket/397#comment:46>
BIND 10 Development <http://bind10.isc.org>
BIND 10 Development


More information about the bind10-tickets mailing list