BIND 10 #444: MemoryZone class

[BIND 10 Development]

#444: MemoryZone class
------------------------------+---------------------------------------------
      Reporter:  vorner       |        Owner:  vorner   
          Type:  task         |       Status:  reviewing
      Priority:  major        |    Milestone:           
     Component:  data source  |   Resolution:           
      Keywords:               |    Sensitive:  0        
Estimatedhours:  0.0          |        Hours:  0        
      Billable:  1            |   Totalhours:  0        
      Internal:  0            |  
------------------------------+---------------------------------------------
Changes (by jinmei):

  * owner:  UnAssigned => vorner


Comment:

 Replying to [comment:1 vorner]:
 > So, it is ready for review in branches/trac444, revisions r3935-r3942.
 >
 It basically looks okay.  One question and some minor points:

 Question: why do you use map for storing RRsets?  Since the number of RR
 types for a single domain name should normally pretty small, I suspect the
 benefit doesn't away its overhead.  I wouldn't oppose to the use of map
 though - this is a short-to-middle term quick implementation anyway, and
 we'll eventually need full optimization probably with a totally different
 data structure, so minor design issues like this don't matter much.
 Adding some comments about the choice would be helpful though.

 Minor nits:
  - copyrights seem odd:
 {{{
 +// Copyright (C) 2010  CZ NIC, Inc. ("ISC")
 }}}
  I guess it's supposed to be either a single line of ISC copyright or a
 multi-line copyright for both CZ NIC and ISC.
  - (not due to this branch but for cleanup) we don't need this doxygen
 markup ("\c"):
 {{{
 +    PARTIALMATCH ///< \c Only a partial match is found.
 }}}
  - MemoryZone documentation: now it has been moved to a different file,
 the doc should be updated accordingly:
 {{{
 +/// \c ZoneTable class.  It will be substantially expanded, and will
 probably
 +/// moved to a separate header file.
 }}}
  - I see no need for new tests with the change, but maybe we should move
 some unittests to new files?

-- 
Ticket URL: <http://bind10.isc.org/ticket/444#comment:2>
BIND 10 Development <http://bind10.isc.org>
BIND 10 Development