BIND 10 #439: Implement normal query processing

BIND 10 Development do-not-reply at isc.org
Thu Dec 23 07:30:40 UTC 2010


#439: Implement normal query processing
-------------------------------+--------------------------------------------
      Reporter:  zzchen_pku    |        Owner:  zzchen_pku
          Type:  task          |       Status:  reviewing 
      Priority:  major         |    Milestone:            
     Component:  Unclassified  |   Resolution:            
      Keywords:                |    Sensitive:  0         
Estimatedhours:  0.0           |        Hours:  0         
      Billable:  1             |   Totalhours:  0         
      Internal:  0             |  
-------------------------------+--------------------------------------------

Comment(by vorner):

 Just one thing I noticed. The MockZone class looks little bit
 overcomplicated. I see no need for pimpl there, as it is technique used to
 hide implementation details away from interface. We don't really hide it,
 it is in the same .cc file and we have no need to hide it, since the class
 is not part of any public API.

 As well, providing it with origin and class makes little sense. It will
 ever be used only as example.com. zone in the IN class, so instead of
 having the constructor parameters, passing them to parameters of the
 MockZoneImpl and storing them, hardcoding the answers to getOrigin and
 getClass seems better (and not remembering any state and not having
 constructor/destructors).

-- 
Ticket URL: <http://bind10.isc.org/ticket/439#comment:4>
BIND 10 Development <http://bind10.isc.org>
BIND 10 Development


More information about the bind10-tickets mailing list