BIND 10 #440: Update of ZoneTable to use the RBTree
BIND 10 Development
do-not-reply at isc.org
Thu Dec 23 07:45:07 UTC 2010
#440: Update of ZoneTable to use the RBTree
------------------------------+---------------------------------------------
Reporter: vorner | Owner: vorner
Type: task | Status: reviewing
Priority: major | Milestone:
Component: data source | Resolution:
Keywords: | Sensitive: 0
Estimatedhours: 0.0 | Hours: 0
Billable: 1 | Totalhours: 0
Internal: 0 |
------------------------------+---------------------------------------------
Changes (by jinmei):
* owner: jinmei => vorner
Comment:
It basically looks okay. I have some comments though.
I'd personally prefer assert()ing things that are not possible to happen
over throwing an "assert exception" as suggested in Sutter/Alexandrescu's
"C++ Coding Standards". Maybe you have your own reason for using an
exception rather than an assertion, and, if so, I would not necessarily
object to that. But ideally we should discuss the policy project-wide so
that we can use a consistent style. And, when using it I believe
AssertError should be defined in isc/exceptions.
--
Ticket URL: <http://bind10.isc.org/ticket/440#comment:3>
BIND 10 Development <http://bind10.isc.org>
BIND 10 Development
More information about the bind10-tickets
mailing list