BIND 10 #447: MemoryZone::find()

[BIND 10 Development]

#447: MemoryZone::find()
------------------------------+---------------------------------------------
      Reporter:  vorner       |        Owner:  vorner   
          Type:  task         |       Status:  reviewing
      Priority:  major        |    Milestone:           
     Component:  data source  |   Resolution:           
      Keywords:               |    Sensitive:  0        
Estimatedhours:  0.0          |        Hours:  0        
      Billable:  1            |   Totalhours:  0        
      Internal:  0            |  
------------------------------+---------------------------------------------
Changes (by hanfeng):

  * owner:  hanfeng => vorner


Comment:

 Replying to [comment:8 vorner]:
 > I wasn't aware of need to store empty domains, but if it is needed for
 something, than let's have them.
 As I know, empty domain is the non-terminal domain
 >
 > > trivial coding style

 > But these exceptions are not module-level. They are class level. Nobody
 else throws them than the class, so the class should contain them. I see
 it better to have names like SomeClass::BadCondition and
 OtherClass::BadCondition than SomeClassBadCondition and [...]
 Sorry for my inaccurate word, module here means MemoryZone. Just like
 classes, exception also has hierarchy, more specific exception is raised
 by specific class. There is no code guildline for exception class
 definition, but please check the code in src/lib/dns, for example name.h,
 all the exceptions are only needed by name class. Personally, I think
 declare the exception on the top is more clear.

 In
 {{{
 result::Result add(const ConstRRsetPtr& rrset)
 }}}
 I see you add check to make sure new added rrset should belong to current
 zone, but I am wondering the steps to add rrset is that, at first, find
 suitable zone in datasrc first, then add rrset into the zone, I am afraid
 the same check will be done in two places.

-- 
Ticket URL: <http://bind10.isc.org/ticket/447#comment:9>
BIND 10 Development <http://bind10.isc.org>
BIND 10 Development