BIND 10 #347: Implement query counters in auth module
BIND 10 Development
do-not-reply at isc.org
Mon Dec 27 20:54:33 UTC 2010
#347: Implement query counters in auth module
------------------------------+---------------------------------------------
Reporter: naokikambe | Owner: y-aharen
Type: enhancement | Status: reviewing
Priority: major | Milestone: y2 12 month milestone
Component: b10-auth | Resolution:
Keywords: | Sensitive: 0
Estimatedhours: 0.0 | Hours: 0
Billable: 1 | Totalhours: 0
Internal: 0 |
------------------------------+---------------------------------------------
Comment(by jinmei):
Replying to [comment:16 y-aharen]:
> There's huge difference between trunk and branches/trac347, I merged the
branch with trunk and committed r4018. Could you please check it?
>
I'm afraid it's beyond the duty of code reviewer, especially when that
person is absurdly busy:-)
From a very quick browse of the diff I didn't find anything obviuosly
wrong.
In general, if the resulting code compiles and all tests pass, it should
be okay unless you resolve possible conflicts in an evil way (e.g.,
removing a test that fails). Our detailed unit tests should do a good job
to detect regression.
--
Ticket URL: <http://bind10.isc.org/ticket/347#comment:18>
BIND 10 Development <http://bind10.isc.org>
BIND 10 Development
More information about the bind10-tickets
mailing list