BIND 10 #451: MemoryZone::load()

[BIND 10 Development]

#451: MemoryZone::load()
------------------------------+---------------------------------------------
      Reporter:  jinmei       |        Owner:  vorner               
          Type:  task         |       Status:  reviewing            
      Priority:  major        |    Milestone:  y2 12 month milestone
     Component:  data source  |   Resolution:                       
      Keywords:               |    Sensitive:  0                    
Estimatedhours:  0.0          |        Hours:  0                    
      Billable:  1            |   Totalhours:  0                    
      Internal:  0            |  
------------------------------+---------------------------------------------

Comment(by vorner):

 Replying to [comment:4 jinmei]:
 > It's probably okay to move forward with the current code for now.  But
 please leave some comments about the possible need for more incremental
 load support somewhere (either or both in memory_datasource.cc and
 auth/config.cc).

 I put one into config.cc and one into memory_datasource.h (as a doxygen
 \todo tag).

 > One minor nit: the opening brace position for add() could be adjusted:

 ACK, done.

 > > >  - You may also want to update MemoryDatasourceConfig::build() (and
 > > >    its tests) so that it will actually load the master file.
 > >
 > > Done
 > >
 > Okay, and I'd add a test case where new_zone->load() throws an
 exception.

 Something like the one I added in r4049?

-- 
Ticket URL: <http://bind10.isc.org/ticket/451#comment:5>
BIND 10 Development <http://bind10.isc.org>
BIND 10 Development