BIND 10 #455: Query processing of NXDOMAIN and NXRRSET

[BIND 10 Development]

#455: Query processing of NXDOMAIN and NXRRSET
-------------------------------+--------------------------------------------
      Reporter:  vorner        |        Owner:  vorner   
          Type:  task          |       Status:  reviewing
      Priority:  major         |    Milestone:           
     Component:  Unclassified  |   Resolution:           
      Keywords:                |    Sensitive:  0        
Estimatedhours:  0.0           |        Hours:  0        
      Billable:  1             |   Totalhours:  0        
      Internal:  0             |  
-------------------------------+--------------------------------------------
Changes (by jinmei):

  * owner:  UnAssigned => vorner


Comment:

 Replying to [comment:1 vorner]:
 > It is ready for review in branches/trac455.
 >
 > Should I add SOA to normal response as well, as it is only one function
 call right now?
 >
 No, we don't need SOA in normal (= positive) responses.  SOA in a negative
 response is necessary for negative caching.  We don't need it for positive
 answers for the obvious reason.

 I have only one substantial comment about the diff: we need a test case
 for missing SOA.

 All others are minor:
 '''query.h'''
  - I would note that this should be a rare case:
 {{{
 +    /// This might throw BadZone or any of its specific subclasses.
 }}}
  - style: no space between the braces? (not in the guideline but for
 overall consistency)
 {{{
         { }
 }}}
  - please add a space before the doxygen comment for readability
 (clarifying what the comment is for)
 {{{
      isc::dns::Message& response_;
 +    /**
 +     * \short Adds a SOA.
 }}}

 '''query_unittest.cc'''
  - is this necessary?
 {{{
 +#include <dns/rdataclass.h>
 }}}

-- 
Ticket URL: <http://bind10.isc.org/ticket/455#comment:2>
BIND 10 Development <http://bind10.isc.org>
BIND 10 Development