BIND 10 #462: b10-auth includes trailing garbage in responses

BIND 10 Development do-not-reply at isc.org
Wed Dec 29 16:57:24 UTC 2010


#462: b10-auth includes trailing garbage in responses
---------------------------+------------------------------------------------
      Reporter:  jinmei    |        Owner:  jinmei               
          Type:  defect    |       Status:  reviewing            
      Priority:  blocker   |    Milestone:  y2 12 month milestone
     Component:  b10-auth  |   Resolution:                       
      Keywords:            |    Sensitive:  0                    
Estimatedhours:  0.0       |        Hours:  0                    
      Billable:  1         |   Totalhours:  0                    
      Internal:  0         |  
---------------------------+------------------------------------------------

Comment(by jinmei):

 Replying to [comment:3 vorner]:
 > The tests looks fine and it responds with reasonable size of data, so I
 think it can be merged.
 >
 Okay, thanks for review.

 > Just out of curiosity, the code inside the operator () was duplicated
 somewhere else as well? Because it just disappeared, and seems not to be
 missed. Is there other part that does the same?
 >
 b10-auth constructs the response message (which is what operator() did (in
 an incomplete way)) as part of query processing.  For example,
 AuthSrvImpl::processNormalQuery() does this here:
 {{{
     MessageRenderer renderer(*buffer);
     const bool udp_buffer =
         (io_message.getSocket().getProtocol() == IPPROTO_UDP);
     renderer.setLengthLimit(udp_buffer ? remote_bufsize : 65535);
     message->toWire(renderer);
 }}}

-- 
Ticket URL: <http://bind10.isc.org/ticket/462#comment:5>
BIND 10 Development <http://bind10.isc.org>
BIND 10 Development


More information about the bind10-tickets mailing list