BIND 10 #454: Zone cut handling in MemoryZone

[BIND 10 Development]

#454: Zone cut handling in MemoryZone
------------------------------+---------------------------------------------
      Reporter:  jinmei       |        Owner:  jinmei               
          Type:  task         |       Status:  assigned             
      Priority:  major        |    Milestone:  y2 12 month milestone
     Component:  data source  |   Resolution:                       
      Keywords:               |    Sensitive:  0                    
Estimatedhours:  0.0          |        Hours:  0                    
      Billable:  1            |   Totalhours:  0                    
      Internal:  0            |  
------------------------------+---------------------------------------------
Changes (by vorner):

  * status:  new => assigned


Comment:

 Few minor points:

 The compiler warned about possibly uninitialized variable „node“ in find.
 As I wanted to run the test, I took the liberty of fixing it, so I put it
 to the repository as well.

 {{{
 +        return (false);         // note: right now this case is
 impossible.
 }}}

 If it is impossible, shouldn't it be assert, just to ensure that the
 impossible doesn't happen?

 {{{
 +    /// \param node On success (either \c EXAMPLE or \c PARTIALMATCH) it
 will
 }}}

 Shouldn't it be EXACTMATCH?

 {{{
 +    // shouldn't confuse the apex node (having NS) with delegation
 +    // test to be added
 +    findTest(origin_, RRType::NS(), Zone::SUCCESS, rr_ns_)
 }}}

 I don't really understand the comment. What test should be added? Like
 something more than just the findTest(…) right there?

-- 
Ticket URL: <http://bind10.isc.org/ticket/454#comment:2>
BIND 10 Development <http://bind10.isc.org>
BIND 10 Development