BIND 10 #454: Zone cut handling in MemoryZone
BIND 10 Development
do-not-reply at isc.org
Wed Dec 29 23:22:30 UTC 2010
#454: Zone cut handling in MemoryZone
------------------------------+---------------------------------------------
Reporter: jinmei | Owner: vorner
Type: task | Status: assigned
Priority: major | Milestone: y2 12 month milestone
Component: data source | Resolution:
Keywords: | Sensitive: 0
Estimatedhours: 0.0 | Hours: 0
Billable: 1 | Totalhours: 0
Internal: 0 |
------------------------------+---------------------------------------------
Comment(by jinmei):
Replying to [comment:3 jinmei]:
> > {{{
> > + return (false); // note: right now this case is
impossible.
> > }}}
> >
> > If it is impossible, shouldn't it be assert, just to ensure that the
impossible doesn't happen?
> >
> In this case I think we can leave it as is. This will soon be updated
in the support for the 'glue OK' mode, which I'll work on next.
>
On a closer look, I changed my mind. This shouldn't happen regardless of
the existence of the 'glue OK' mode. I modified the code using assert()
in r4086.
> > I don't really understand the comment. What test should be added? Like
something more than just the findTest(…) right there?
> >
> Hmm, I don't understand the comment either:-) What about this?
{{{
// finding NS for the apex (origin) node. This must not be confused
// with delegation due to the existence of an NS RR.
findTest(origin_, RRType::NS(), Zone::SUCCESS, rr_ns_);
}}}
>
The proposed revised comment was committed in r4085.
--
Ticket URL: <http://bind10.isc.org/ticket/454#comment:4>
BIND 10 Development <http://bind10.isc.org>
BIND 10 Development
More information about the bind10-tickets
mailing list