BIND 10 #463: "glue OK" mode for (Memory)Zone::find()

BIND 10 Development do-not-reply at isc.org
Thu Dec 30 10:57:44 UTC 2010


#463: "glue OK" mode for (Memory)Zone::find()
------------------------------+---------------------------------------------
      Reporter:  jinmei       |        Owner:  jinmei               
          Type:  task         |       Status:  reviewing            
      Priority:  major        |    Milestone:  y2 12 month milestone
     Component:  data source  |   Resolution:                       
      Keywords:               |    Sensitive:  0                    
Estimatedhours:  0.0          |        Hours:  0                    
      Billable:  1            |   Totalhours:  0                    
      Internal:  0            |  
------------------------------+---------------------------------------------
Changes (by vorner):

  * owner:  vorner => jinmei


Comment:

 Just one thing:

 {{{
 return ((state->options_ & FIND_GLUE_OK) != 0 ? false : true)
 }}}

 This seems unnecesarilly complicated. Wouldn't return(!(state->options_ &
 FIND_GLUE_OK)); be better? The only thing that the condition does is
 negation.

 Otherwise it seems to be OK to merge.

-- 
Ticket URL: <http://bind10.isc.org/ticket/463#comment:4>
BIND 10 Development <http://bind10.isc.org>
BIND 10 Development


More information about the bind10-tickets mailing list