BIND 10 #270: need unistd.h included on sunstudio

[BIND 10 Development]

#270: need unistd.h included on sunstudio
--------------------------+-------------------------------------------------
 Reporter:  jreed         |       Owner:     
     Type:  defect        |      Status:  new
 Priority:  major         |   Milestone:     
Component:  Unclassified  |    Keywords:     
Sensitive:  0             |  
--------------------------+-------------------------------------------------
 {{{
 Index: src/lib/xfr/fd_share.cc
 ===================================================================
 --- src/lib/xfr/fd_share.cc     (revision 2387)
 +++ src/lib/xfr/fd_share.cc     (working copy)
 @@ -20,6 +20,7 @@
  #include <sys/types.h>
  #include <sys/socket.h>
  #include <sys/uio.h>
 +#include <stdlib.h>             // for malloc and free
  #include "fd_share.h"

  namespace isc {
 Index: src/lib/xfr/xfrout_client.cc
 ===================================================================
 --- src/lib/xfr/xfrout_client.cc        (revision 2387)
 +++ src/lib/xfr/xfrout_client.cc        (working copy)
 @@ -18,6 +18,8 @@
  #include <cstring>
  #include <iostream>

 +// for some IPC/network system calls in
 asio/detail/pipe_select_interrupter.hpp
 +#include <unistd.h>
  #include <asio.hpp>

  #include "fd_share.h"
 Index: src/lib/cc/session_unittests.cc
 ===================================================================
 --- src/lib/cc/session_unittests.cc     (revision 2387)
 +++ src/lib/cc/session_unittests.cc     (working copy)
 @@ -16,6 +16,8 @@

  #include "config.h"

 +// for some IPC/network system calls in
 asio/detail/pipe_select_interrupter.hpp
 +#include <unistd.h>
  // XXX: the ASIO header must be included before others.  See session.cc.
  #include <asio.hpp>

 }}}

 But src/lib/cc/session.cc says:

 {{{
 // XXX: there seems to be a strange dependency between ASIO and std
 library
 // definitions.  On some platforms if we include std headers before ASIO
 // headers unexpected behaviors will happen.
 // A middle term solution is to generalize our local wrapper interface
 // (currently only available for the auth server), where all such
 portability
 // issues are hidden, and to have other modules use the wrapper.
 #include <unistd.h>             // for some IPC/network system calls
 #include <asio.hpp>
 #include <asio/error_code.hpp>
 #include <asio/system_error.hpp>

 }}}

-- 
Ticket URL: <http://bind10.isc.org/ticket/270>
BIND 10 Development <http://bind10.isc.org>
BIND 10 Development