BIND 10 #271: build failure with sunstudio in rrttl_python.cc and rrtype_python.cc

[BIND 10 Development]

#271: build failure with sunstudio in rrttl_python.cc and rrtype_python.cc
---------------------------+------------------------------------------------
 Reporter:  jreed          |        Owner:  jelte                      
     Type:  defect         |       Status:  reviewing                  
 Priority:  major          |    Milestone:  06. 4th Incremental Release
Component:  DNSPacket API  |   Resolution:                             
 Keywords:                 |    Sensitive:  0                          
---------------------------+------------------------------------------------
Changes (by jinmei):

  * owner:  => jelte
  * status:  new => reviewing
  * component:  Unclassified => DNSPacket API
  * milestone:  => 06. 4th Incremental Release


Comment:

 Replying to [comment:1 jreed]:
 > See 271.diff patch from jelte.

 This patch isn't exception safe.  Please see my counter patch (attaching
 it).

 As a general rule of thumb, new'ing a temporary region this way almost
 always introduces this type of bug and should be avoided.

 > +if USE_GXX
 > +AM_CPPFLAGS += -Wno-write-strings
 > +endif

 > But I don't know if this is needed -- not used on Sunstudio.

 This may not be necessary to make it compile, but it's better to have it.
 Please commit that part.

 I'll give this ticket to Jelte for the main patch.

-- 
Ticket URL: <http://bind10.isc.org/ticket/271#comment:2>
BIND 10 Development <http://bind10.isc.org>
BIND 10 Development