BIND 10 #259: b10-auth and bind10 cleanup comments

[BIND 10 Development]

#259: b10-auth and bind10 cleanup comments
--------------------------+-------------------------------------------------
 Reporter:  each          |        Owner:  each    
     Type:  defect        |       Status:  accepted
 Priority:  major         |    Milestone:          
Component:  Unclassified  |   Resolution:          
 Keywords:                |    Sensitive:  0       
--------------------------+-------------------------------------------------

Comment(by each):

 > > __check_axfr_query__
 > > __dispatch_axfr_query__

 This is all being rewritten in trac #221, so I'll leave it as it is for
 now.

 > > __class TCPClient__
 > > No indication given should an error occur; instead the object silently
 disappears.

 > > __class UDPServer__
 > > Does not appear to be any logging should an error occur in the receive
 function, nor if a zero-length message is received.

 > > "env" is an argument to the !ProcessInfo constructor.  Why have the
 tests for the initialization of this member been commented out?

 The top of the file says:
 # XXX: environment tests are currently disabled, due to the preprocessor
 #      setup that we have now complicating the environment

 > > __TestBob__
 > > Only checks that the arguments have been stored correctly.  What tests
 are done that the other methods work?

 The other methods all relate to other modules -- config handler and
 command handler interact with msgq; startup and shutdown with everything.
 I'm not sure how we can unit test these things.  However, I'll request
 that Shane give it some consideration.

 > > Remark: As this class creates a process, to my untutored eyes
 !ProcessInfo seems a misleading name.

 I agree, and changed it to Process in the trac259 branch.  Checkpointing,
 and then I'll handle Shane's remarks.

-- 
Ticket URL: <http://bind10.isc.org/ticket/259#comment:3>
BIND 10 Development <http://bind10.isc.org>
BIND 10 Development