BIND 10 #275: refactoring CC session class for easier tests

[BIND 10 Development]

#275: refactoring CC session class for easier tests
----------------------------------------+-----------------------------------
 Reporter:  jinmei                      |        Owner:  jinmei                     
     Type:  enhancement                 |       Status:  reviewing                  
 Priority:  major                       |    Milestone:  06. 4th Incremental Release
Component:  Inter-module communication  |   Resolution:                             
 Keywords:                              |    Sensitive:  0                          
----------------------------------------+-----------------------------------
Changes (by jelte):

  * owner:  jelte => jinmei


Comment:

 The header file documentation was apparently already lagging behind the
 actual api, but now even more so :) (especially some information in
 ccsession.h about how the session should be passed, and what a caller
 would have to do, or that the caller would not be expected to do anything,
 which seems to be the case, since establish() is called in the constructor
 of CCSession).

 For that matter, should we think about having another one where the user
 doesn't have to pass a Session, and let the ModuleCCSession take care of
 it, in case the caller really doesn't care?

 For the sake of consistency, while not exactly essential, should we make
 *ccsession and *cs stack objects in auth's main.cc (and perhaps then
 rethink how we can do the same for auth_srv and io_service)?

 auth_srv.h declares a setSession() now, but it doesn't actually seem to be
 defined anywhere (or used, obviously :)) I suspect that this is a leftover
 and should be removed.

 Rest looks good.

-- 
Ticket URL: <https://bind10.isc.org/ticket/275#comment:2>
BIND 10 Development <http://bind10.isc.org>
BIND 10 Development