BIND 10 #288: "use after destroy" in sqlite3_datasrc (which breaks sunstudio)

[BIND 10 Development]

#288: "use after destroy" in sqlite3_datasrc (which breaks sunstudio)
------------------------------+---------------------------------------------
      Reporter:  jinmei       |        Owner:  UnAssigned                 
          Type:  defect       |       Status:  reviewing                  
      Priority:  critical     |    Milestone:  06. 4th Incremental Release
     Component:  data source  |   Resolution:                             
      Keywords:               |    Sensitive:  0                          
Estimatedhours:  0            |        Hours:  0                          
      Billable:  1            |   Totalhours:  0                          
      Internal:  0            |  
------------------------------+---------------------------------------------

Comment(by jinmei):

 Alternatively we could use SQLITE_TRANSIENT for sqlite3_bind_text instead
 of defining temporary string objects.  We discussed this on jabber:

 ---
 jinmei
 1:48
 I didn't choose it because it would be a slightly less efficient, but
 since this code path is already pretty heavy it might make more sense to
 force a copy.
 I'm fine with either policy.
 the copy approach would make the code simpler, too, since we wouldn't need
 to define a temporary variable.

 each
 1:50
 I like your first instinct, let's avoid copies even though the database
 lookup is already slow
 ---

 And no objection to that, so we'll keep the current patch.

 It was approved on jabber.

-- 
Ticket URL: <http://bind10.isc.org/ticket/288#comment:2>
BIND 10 Development <http://bind10.isc.org>
BIND 10 Development