BIND 10 #197: loadzone allow optional comment for $TTL per rfc2308

[BIND 10 Development]

#197: loadzone allow optional comment for $TTL per rfc2308
---------------------------+------------------------------------------------
      Reporter:  jreed     |        Owner:  jreed    
          Type:  defect    |       Status:  reviewing
      Priority:  major     |    Milestone:           
     Component:  loadzone  |   Resolution:           
      Keywords:            |    Sensitive:  0        
Estimatedhours:            |        Hours:           
      Billable:  1         |   Totalhours:           
      Internal:  0         |  
---------------------------+------------------------------------------------
Changes (by jinmei):

  * internal:  => 0
  * billable:  => 1


Comment:

 Just checking: r2340 seems quite big, and it seems to contain other
 changes that are irrelevant to the subject of this ticket.

 Which part of it is requested to be reviewed?  If it's part of the
 diff, please specify which is to be reviewed.

 One quick comment btw: I suspect parse_ttl could yield an invalid
 value for TTL that is, an integer larger than 0xffffffff.  I also
 suspect it could accept various kind of invalid form such as:
   - 1.5
   - 2X
   - "1D 1M"

 It also accepts "1D1D".  I'm not sure if it's intentional (for that
 matter BIND 9 also seems to accept it).

 Another point I just happened to notice: why ttl_regex is explicitly
 declared as global?
 {{{
 ttl_regex = re.compile('([0-9]+[wdhms]?)+', re.I)
 def isttl(s):
     global ttl_regex
     if ttl_regex.match(s):
         return True
     else:
         return False
 }}}

 Since it's used as a read-only object in this context, this global
 should be redundant.

-- 
Ticket URL: <http://bind10.isc.org/ticket/197#comment:8>
BIND 10 Development <http://bind10.isc.org>
BIND 10 Development